Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(13694): Fix Link warnings #13854

Merged

Conversation

speedfl
Copy link
Contributor

@speedfl speedfl commented May 31, 2023

Closes [ #13694 ]

When using App in any namespace, appNamespace is not forwarded to getLinks endpoint. Therefore the control plane namespace is used and apps does not exist in this namespace

To reproduce:

make start-e2e-local

Create following manifest and sync:

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: test-namespaced-links
  namespace: argocd-e2e-external
spec:
  destination:
    namespace: guestbook
    server: https://kubernetes.default.svc
  project: default
  source:
    path: guestbook
    repoURL: https://github.com/speedfl/argocd-example-apps.git
    targetRevision: feature/test-edit-app-in-any-namespace 

Look at the new created link http://titi.toto.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • X ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

image

@speedfl speedfl changed the title Fix(13694): Fix Link warnings fix(13694): Fix Link warnings May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (ec2340a) 49.48% compared to head (aafb2ea) 49.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13854      +/-   ##
==========================================
- Coverage   49.48%   49.47%   -0.01%     
==========================================
  Files         256      256              
  Lines       43847    43847              
==========================================
- Hits        21697    21694       -3     
- Misses      19988    19990       +2     
- Partials     2162     2163       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

server/application/application.proto Outdated Show resolved Hide resolved
Signed-off-by: Geoffrey Muselli <[email protected]>
@speedfl speedfl force-pushed the feature/apps-any-namespace-warning-link branch from 0ad1357 to 970d514 Compare June 1, 2023 12:47
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit f8d0d59 into argoproj:master Jun 2, 2023
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.7

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 2, 2023
crenshaw-dev pushed a commit that referenced this pull request Jun 2, 2023
Signed-off-by: Geoffrey Muselli <[email protected]>
Co-authored-by: Geoffrey MUSELLI <[email protected]>
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.6

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 14, 2023
crenshaw-dev pushed a commit that referenced this pull request Jul 14, 2023
Signed-off-by: Geoffrey Muselli <[email protected]>
Co-authored-by: Geoffrey MUSELLI <[email protected]>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
…j#13890)

Signed-off-by: Geoffrey Muselli <[email protected]>
Co-authored-by: Geoffrey MUSELLI <[email protected]>
Signed-off-by: schakrad <[email protected]>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants