-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(13694): Fix Link warnings #13854
fix(13694): Fix Link warnings #13854
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #13854 +/- ##
==========================================
- Coverage 49.48% 49.47% -0.01%
==========================================
Files 256 256
Lines 43847 43847
==========================================
- Hits 21697 21694 -3
- Misses 19988 19990 +2
- Partials 2162 2163 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Geoffrey Muselli <[email protected]>
0ad1357
to
970d514
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cherry-pick release-2.7 |
Signed-off-by: Geoffrey Muselli <[email protected]>
Signed-off-by: Geoffrey Muselli <[email protected]> Co-authored-by: Geoffrey MUSELLI <[email protected]>
/cherry-pick release-2.6 |
Signed-off-by: Geoffrey Muselli <[email protected]>
Signed-off-by: Geoffrey Muselli <[email protected]> Co-authored-by: Geoffrey MUSELLI <[email protected]>
…j#13890) Signed-off-by: Geoffrey Muselli <[email protected]> Co-authored-by: Geoffrey MUSELLI <[email protected]> Signed-off-by: schakrad <[email protected]>
Signed-off-by: Geoffrey Muselli <[email protected]>
Signed-off-by: Geoffrey Muselli <[email protected]>
Closes [ #13694 ]
When using App in any namespace,
appNamespace
is not forwarded togetLinks
endpoint. Therefore the control plane namespace is used and apps does not exist in this namespaceTo reproduce:
Create following manifest and sync:
Look at the new created link
http://titi.toto.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.